Commit c8e796c
Refactor OIDC implementation following review feedback
- Moved GetOIDCConfig logic to BaseEngine with GetOIDCConfigWithDefault helper
- Added defaultOIDCConfig field to ClaudeEngine struct (initialized in constructor)
- Added GetOAuthTokenEnvVar and GetApiTokenEnvVar methods to OIDCConfig type
- Removed GetOIDCConfig from Codex and Copilot engines (they inherit from BaseEngine)
- Readded missing 'if' condition to OIDC setup step for secret presence check
- All OIDC tests passing, code formatted and linted
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>1 parent 303e5cc commit c8e796c
57 files changed
Lines changed: 3311 additions & 114721 deletions
File tree
- .github/workflows
- pkg/workflow
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments