From dc7a9f06cebb2f7187e7e5637886bf20cc08d09e Mon Sep 17 00:00:00 2001 From: ualtinok <94532+ualtinok@users.noreply.github.com> Date: Mon, 26 Oct 2026 21:50:42 +0100 Subject: [PATCH] Give the wait:true bash test 20 s instead of 5 s It checks that wait:true returns the command's terminal output, not how fast the command runs. On a loaded Windows runner the shell plus two printfs around a 1 s sleep took over 5 s and the timeout killed it (merge queue run 40395629042). 20 s stays under the test's 30 s frame read deadline. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> --- .../slice-descriptors/land-wait-true-test-budget.json | 8 ++++++++ crates/aft/tests/integration/subc_bridge_test.rs | 6 +++++- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 benchmarks/aft-search/slice-descriptors/land-wait-true-test-budget.json diff --git a/benchmarks/aft-search/slice-descriptors/land-wait-true-test-budget.json b/benchmarks/aft-search/slice-descriptors/land-wait-true-test-budget.json new file mode 100644 index 0000000000..ebd574711e --- /dev/null +++ b/benchmarks/aft-search/slice-descriptors/land-wait-true-test-budget.json @@ -0,0 +1,8 @@ +{ + "targeted_mechanism": "none", + "kind": "harness", + "slice_class": "non_ranking", + "fixtures": [ + "harness-goldens" + ] +} diff --git a/crates/aft/tests/integration/subc_bridge_test.rs b/crates/aft/tests/integration/subc_bridge_test.rs index daee3ba933..09db95c237 100644 --- a/crates/aft/tests/integration/subc_bridge_test.rs +++ b/crates/aft/tests/integration/subc_bridge_test.rs @@ -5018,7 +5018,11 @@ async fn drive_bash_wait_true_daemon(input: FakeDaemonInput) { "command": "printf 'wait-early\\n'; sleep 1; printf 'wait-late\\n'", "foreground_orchestrate": true, "wait": true, - "timeout": 5_000, + // The test checks that wait:true returns terminal output, not how + // fast the command runs: a loaded Windows runner can take over 5 s + // to start the shell and its two printfs around the 1 s sleep. + // Stays under read_frame_timeout's 30 s so a kill still answers. + "timeout": 20_000, "compressed": false, }), )