From fd1c4eadc7052f138b7b294b9c70cdeaa3362159 Mon Sep 17 00:00:00 2001 From: Rudy Celekli Date: Sun, 1 Nov 2026 11:52:15 -0500 Subject: [PATCH] Preserve carriage returns through XML output round trips --- carriage_return_test.go | 33 +++++++++++++++++++++++++++++++++ node.go | 5 +++-- 2 files changed, 36 insertions(+), 2 deletions(-) create mode 100644 carriage_return_test.go diff --git a/carriage_return_test.go b/carriage_return_test.go new file mode 100644 index 0000000..8e1265f --- /dev/null +++ b/carriage_return_test.go @@ -0,0 +1,33 @@ +package jsonquery + +import ( + "encoding/xml" + "io" + "strings" + "testing" +) + +func TestOutputXMLPreservesCarriageReturns(t *testing.T) { + doc, err := Parse(strings.NewReader(`{"v":"a\rb\r\nc\td\ne & < >"}`)) + if err != nil { + t.Fatal(err) + } + want := "a\rb\r\nc\td\ne & < >" + var got strings.Builder + d := xml.NewDecoder(strings.NewReader(doc.OutputXML())) + for { + tok, err := d.Token() + if err == io.EOF { + break + } + if err != nil { + t.Fatal(err) + } + if x, ok := tok.(xml.CharData); ok { + got.Write([]byte(x)) + } + } + if got.String() != want { + t.Errorf("decoded text=%q, want%q", got.String(), want) + } +} diff --git a/node.go b/node.go index c6ad66a..475d4d3 100644 --- a/node.go +++ b/node.go @@ -81,8 +81,9 @@ func (n *Node) InnerText() string { } // xmlTextEscaper escapes the characters that are not allowed to appear -// literally in XML character data. -var xmlTextEscaper = strings.NewReplacer("&", "&", "<", "<", ">", ">") +// literally in XML character data. Carriage returns must be references because +// XML parsers otherwise normalize them to line feeds. +var xmlTextEscaper = strings.NewReplacer("&", "&", "<", "<", ">", ">", "\r", " ") func outputXML(b *strings.Builder, n *Node, level int, skip bool) { level++