From f5732b81a2d98a9ad9d64087145dfbb4b6d33847 Mon Sep 17 00:00:00 2001 From: Katharine Hyatt Date: Mon, 19 Oct 2026 08:59:17 +0200 Subject: [PATCH 1/2] Have right_null match left_null's SVD alg behavior `left_null` checks the kwargs for `:svd`, `right_null` currently doesn't, so actually the default algorithm is always used there --- src/interface/orthnull.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interface/orthnull.jl b/src/interface/orthnull.jl index 51541dcc4..ed58a0e36 100644 --- a/src/interface/orthnull.jl +++ b/src/interface/orthnull.jl @@ -389,7 +389,7 @@ end return RightNullViaLQ(alg) end @inline function select_algorithm(::typeof(right_null!), A, ::Val{:svd}; trunc = nothing, kwargs...) - alg_svd = select_algorithm(svd_full!, A; kwargs...) + alg_svd = select_algorithm(svd_full!, A; get(kwargs, :svd, nothing)) alg = TruncatedAlgorithm(alg_svd, select_null_truncation(A, trunc)) return RightNullViaSVD(alg) end From 345eead062ba9888f7bfa90a192222c6faf4d87d Mon Sep 17 00:00:00 2001 From: Katharine Hyatt Date: Mon, 19 Oct 2026 09:01:41 +0200 Subject: [PATCH 2/2] Dumb typo --- src/interface/orthnull.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interface/orthnull.jl b/src/interface/orthnull.jl index ed58a0e36..34537e078 100644 --- a/src/interface/orthnull.jl +++ b/src/interface/orthnull.jl @@ -389,7 +389,7 @@ end return RightNullViaLQ(alg) end @inline function select_algorithm(::typeof(right_null!), A, ::Val{:svd}; trunc = nothing, kwargs...) - alg_svd = select_algorithm(svd_full!, A; get(kwargs, :svd, nothing)) + alg_svd = select_algorithm(svd_full!, A, get(kwargs, :svd, nothing)) alg = TruncatedAlgorithm(alg_svd, select_null_truncation(A, trunc)) return RightNullViaSVD(alg) end