You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When thrift@0.7.0 receives an error and tries to call the function on the client object through client['recv_' + header.fname](message, header.mtype, dummy_seqid); (line #83 of thrift/lib/thrift/connection.js of thrift@0.7.0), header.fname = 'log'. The associated function is defined here: https://github.com/Applifier/node-scribe/blob/master/lib/gen-nodejs/scribe.js#L156, as recv_Log (capital L instead of lowercase like header.fname). This causes thrift@0.7.0 to choke and the app to crash.
When
thrift@0.7.0receives an error and tries to call the function on the client object throughclient['recv_' + header.fname](message, header.mtype, dummy_seqid);(line #83 ofthrift/lib/thrift/connection.jsofthrift@0.7.0),header.fname = 'log'. The associated function is defined here: https://github.com/Applifier/node-scribe/blob/master/lib/gen-nodejs/scribe.js#L156, asrecv_Log(capitalLinstead of lowercase likeheader.fname). This causesthrift@0.7.0to choke and the app to crash.Issue #7 would resolve this issue for the most part, as the latest version of
thriftchecks for the existence ofclient['recv_' + header.fname]before invoking it, https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/connection.js;h=23cb01c79b6b839f020bfcb67bc0875221e94564;hb=HEAD#l138